Parser: Fix Qualys Parser Mitigation Date Issue #9888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Finding-Model requires a DateTime Field which is not compatible and imports are getting canceled
|
Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.
Note 🟢 Risk threshold not exceeded. Tip Get answers to your security questions. Add a comment in this PR starting with @DryRunSecurity. For example... Powered by DryRun Security |
Maffooch
approved these changes
Apr 8, 2024
cneill
approved these changes
Apr 10, 2024
|
Hi, |
|
Guys, we are still stuck with 3 approvals :/ |
hblankenship
approved these changes
Apr 30, 2024
dogboat
pushed a commit
to dogboat/django-DefectDojo
that referenced
this pull request
May 6, 2024
… the Finding-Model requires a DateTime Field which is not compatible and imports are getting canceled (DefectDojo#9888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are narrowing the scope of acceptable enhancements to DefectDojo in preparation for v3. Learn more here:
https://github.com/DefectDojo/django-DefectDojo/blob/master/readme-docs/CONTRIBUTING.md
Description
The Parser used a Date Field for the mitigation_date, however… the Finding-Model requires a DateTime Field which is not compatible and imports are getting canceled. The fix is simply to remove the "to_date" conversion, because we do not want to change the Finding Model
Test results
Ideally you extend the test suite in
tests/anddojo/unitteststo cover the changed in this PR.Alternatively, describe what you have and haven't tested.
Documentation
Please update any documentation when needed in the documentation folder)
Checklist
This checklist is for your information.
dev.dev.bugfixbranch.